QA Session Recordings

ComfyUI Frontend · Automated QA · PR #10336 · main @ 7c6ab19 · #10336 @ 1c5d6e2
🐧LinuxReport
Before main
After PR
AI Comparative Review
# linux QA Video Report - Generated at: 2026-03-24T05:21:16.244Z - Model: `gemini-3-flash-preview` - Target: https://github.com/Comfy-Org/ComfyUI_frontend/pull/10336 - Before video: `./qa-artifacts/qa-report-Linux-23474290162/qa-before-session.mp4` (2.6 MB) - After video: `./qa-artifacts/qa-report-Linux-23474290162/qa-session.mp4` (2.6 MB) - Mode: **Comparative (before/after)** ## AI Review ## Summary The PR #10336 aims to fix a regression where workflow tabs were lost whenever the browser was closed and reopened. This was caused by moving tab pointers to `sessionStorage` (which is cleared on browser close). The fix implements dual-writing to both `sessionStorage` (for per-tab isolation) and `localStorage` (as a persistent fallback). **Observation**: The provided **BEFORE** and **AFTER** videos are virtually identical. Both show the setup phase of a test: logging in, viewing the default workflow, opening/closing the templates menu, and creating a second workflow tab. **Conclusion**: Neither video demonstrates the actual bug (loss of tabs on restart) or the fix (restoration of tabs on restart), as the videos end before any page reload or browser restart simulation occurs. However, they do confirm that basic tab creation and UI navigation remain functional. ## Behavior Changes | Behavior | Before (main) | After (PR) | Verdict | | :--- | :--- | :--- | :--- | | **Workflow Tab Creation** | Successfully creates a second tab ("Unsaved Workflow (2)"). | Successfully creates a second tab ("Unsaved Workflow (2)"). | `No Change` | | **Templates Navigation** | Templates menu opens, scrolls, and closes normally. | Templates menu opens, scrolls, and closes normally. | `No Change` | | **Tab Persistence** | Not demonstrated; no restart/reload shown. | Not demonstrated; no restart/reload shown. | `Not Verified` | ## Timeline Comparison | Time | Type | Severity | Before (main) | After (PR) | | :--- | :--- | :--- | :--- | :--- | | 0:01-0:03 | State | None | User selects "qa-ci" and logs in. | User selects "qa-ci" and logs in. | | 0:04 | Layout | None | Single tab "Unsaved Workflow" is visible. | Single tab "Unsaved Workflow" is visible. | | 0:05-0:08 | Menu | None | Templates menu is opened, scrolled, and closed. | Templates menu is opened, scrolled, and closed. | | 0:11-0:13 | Behavior | None | User clicks the "+" button; a second workflow tab appears. | User clicks the "+" button; a second workflow tab appears. | ## Confirmed Issues No visual regressions or issues were observed in the provided clips. The basic UI functionality for workflows remains stable. --- ## Possible Issues (Needs Human Verification) * **Restart Verification**: The provided videos do not show the page being reloaded or the browser being "restarted" (which in an automated test environment usually involves clearing `sessionStorage` and reloading). As such, the fix for Comfy-Org/ComfyUI#12984 cannot be visually confirmed from these specific clips alone. Reliance on the included automated playwright tests (`interaction.spec.ts`) is necessary to confirm the restoration logic works as intended. ## Overall Risk **Low**. The PR addresses a specific data-persistence regression by adding a secondary storage layer. While the videos only show that the "happy path" of creating tabs is unaffected, the code diff shows robust logic (guards and validation) for the new storage fallback. The risk of breaking existing functionality is minimal as `sessionStorage` remains the primary source of truth during an active session.